simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Version 50+ having trouble picking up initial notifications. #503

Closed djryan closed 5 years ago

djryan commented 5 years ago

There was on scrobble in the cache, which got pushed to last.fm, but it can't pick up any more. I've uninstaller, reset caches and removed local data, but it's still not noticing that anything new has been played (to push to the now playing api) or has been played.

a-r-db commented 5 years ago

Well that's really not good.

a-r-db commented 5 years ago

This is my apk or the playstore version?

djryan commented 5 years ago

Double checked and it seems to be both. Might be something in the app detection code; I can't get it to pick up new apps either.

a-r-db commented 5 years ago

Strange. Have you tried Exiting the app? I added an exit button on the initial screen. Sometimes this helps. This is really bad news. I did not change any of the code there.

a-r-db commented 5 years ago

@djryan Ok I recreated your bug. There is an app clash problem upon initial install I believe. If I use music player apps that previously used Broadcast intents it clashes.

Do you happen to know if all the apps you have been trying use broadcast intents in the old way?

a-r-db commented 5 years ago

I looked at Androids example mediamanager external player app and found out the real issue. Thanks so much for pointing this issue out.

a-r-db commented 5 years ago

508

I will reopen should this update fail to resolve your stated issue.

WolfFhang commented 5 years ago

Moving conversation from #507 to here like I was told earlier.

After trying 1.6.2 using multiple media players (Youtube, Play Music, GMMP) SLS still doesn't pick up any of the apps in the "Enabled Apps" section, nor can I get it to scrobble. Not sure if others are still having issues on 1.6.2

Also a potentially unrelated Issue that might need a separate thread, the stats from the older version (1.5.7 in my case) are still missing in the last several updates (1.6.0-1.6.2 etc), yet if I revert to version 1.5.7 the Stats show up fine and are still there

a-r-db commented 5 years ago

Yes, stats are not typically kept through versions. I will add that to my todo list.

a-r-db commented 5 years ago

However, version 1.6.2 should pick up new music players now. Did you enable the Notification Listener AKA Notification Access permissions?

WolfFhang commented 5 years ago

Ah it seems I was mistaken, I went and made sure I had that permission enabled and it was off/not allowed. After allowing that Notification permission it seems as though at least the Now Playing portion is working, but songs aren't scrobbling once finished.

I was a bit confused because I saw we were now allowed to skip the permission if we didn't want to enable them all. I was under the assumption that the Notification Access was only needed if you used the Active App Notification option

Edit: Also I cleared out my enabled apps and I was able to re-add GMMP afterword without issue