simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
551 stars 100 forks source link

Not-logged-in warning #550

Open MartinL0815 opened 4 years ago

MartinL0815 commented 4 years ago

I'm logged in into libre.fm and Listenbrainz, but not into last.fm. Since libre.fm is forwarding scrobbles to last.fm there's no need to log in. So this warming is unnecessary for last.fm, where can I deactivate this warming?

MartinL0815 commented 4 years ago

Since I always swipe away the not-logged-in warning, Android Pie now asks me if still to display this notification. What happens, if I choose "don't show again"? What in SImpleScrobbler won't get notified anymore?

BTW - this warning is really annoying, since it is not important! I have two accounts logged in, but not last.fm. Why not an option to warn or not? Or an account/service specific option to warn or not?

a-r-db commented 4 years ago

@MartinL0815 Thanks for the information. This is a genuine issue. I am not entirely sure why this is not working, although I am trying to recreate the scenario. This could be the bad code

I made sure they are code blocks for now, although that may not be the problem there.

a-r-db commented 4 years ago

This following apk should function well. Not 100% certain it will fix the problem, but it's worth a try. app-debug.zip

kidd73 commented 3 years ago

Thanks, I'll try.