search

simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Metered WiFi #553

Open 101lols opened 5 years ago

101lols commented 5 years ago

The app doesn't respect metered WiFis.

https://developer.android.com/reference/android/support/v4/net/ConnectivityManagerCompat#isActiveNetworkMetered(android.net.ConnectivityManager)

inverse commented 5 years ago

What would you expect the app to do in such conditions?

e.g. if the user has set to only scrobble on wifi for example? should it just not if the current network is metered?

101lols commented 5 years ago

Personally, yes. Most apps that don't ignore the Metered WiFi check treat Metered WiFis as Mobile Data (e.g. almost all google apps, NewPipe). Which makes sense, Metered WiFis are often going to be mobile hotspots running on someone else's mobile data.

a-r-db commented 5 years ago

I'm keeping this one between a bug and a feature because I understand the issue but there are a few bugs atm that are more critical for me.