search

simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Correction rules are not reflected in scrobbles #557

Open onnyyonn opened 5 years ago

onnyyonn commented 5 years ago

Bug: Setting correction rules doesn't correct the scrobbles.

Description: If I have understood correctly, I can change the metadata on the fly while scrobbling a track, using correction rules. I created a rule to change Artist Fossils to Rupam Islam and played a few tracks of Fossils in YouTube Music. But the scrobbles still show the artist Fossils.

How to Reproduce:

  1. Correction Rules > Add New Rule
  2. Type Fossils in Artist Title field and Rupam Islam in New Artist Title field. Leave other fields empty.
  3. Play Fossils tracks in YouTube Music.
a-r-db commented 5 years ago

@onnyyonn I understand this issue, but this falls under #489 somewhat The main issue is the most track metadata is met on a per track basis (aka per scrobble basis) This would mean leaving title and album undefined is undesirable. There may be a temporary workable patch for this use-case.

snakecase commented 4 years ago

Same here. I listen to a radio stream which sets their URL into the "Album" field so Last.fm returns "ignoredMessage":{"code":"1","#text":"" Tried to create a rule to replace the said URL in the "Album" field with an empty line but SLS didn't enforce the rule. Also tried to replace with some text to no avail. I basically left all the other fields empty. Maybe there is something I could put in them so they get ignored explicitly?

Thanks.