simple-login / Simple-Login-Android

Android client for SimpleLogin
https://play.google.com/store/apps/details?id=io.simplelogin.android
Other
354 stars 39 forks source link

Offline List of Aliases #62

Open cheeseyfish opened 2 years ago

cheeseyfish commented 2 years ago

Hello, first of all I love the SimpleLogin application.

My suggestion is as follows: offline access to email names. Scenario: I am out and about and confronted with a situation in which I need a SimpleLogin alias email address. I take my phone out and try to log on to SimpleLogin. I find out I do not have internet access in this particular location, so I cannot log on to see my list of aliases. Solution: Keep an offline list of aliases and display it in the event that one cannot log in for whatever reason. Can be opt-in.

Thank you for this amazing application.

ntnhon commented 2 years ago

Hello, it's actually a great feature but I think it needs some work on BE side. @nguyenkims from what I see we'll need an endpoint that takes an array of alias ids as input and returns an array of aliases with updated information.

nguyenkims commented 2 years ago

Keeping track of all changes related to an alias is actually quite hard as the change can come from anywhere (custom domain, PGP, mailboxes, etc).

I think there's maybe easier solution (but inefficient) that we can use is to cache the API result and let the UI read from the cache instead of directly using the API response. This way if ever the app doesn't have internet, the data is going to be loaded from cache.

ntnhon commented 2 years ago

@nguyenkims I mean the information at the time of requesting, no need to keep track of the changes. This endpoint will be used to refresh the offline aliases.

nguyenkims commented 2 years ago

@ntnhon oh I see, you mean something like "GET /api/v2/aliases" but has an alias_ids filter that allow to only return aliases listed in the filter right?

ntnhon commented 2 years ago

@nguyenkims yes that's what I mean

cheeseyfish commented 2 years ago

Thank you for interest in my issue. Please provide an XMR address so we can throw some donations your way.

nguyenkims commented 2 years ago

@cheeseyfish thanks! Our XMR address is 48R8eccu9eQbZYkhkhj99o4uERJPNZXvAhvLr9YCULx9UhAEqocmHTMPgMBhTXGdbnXecQcB2JEBKUQV4sGgdURZTZz74EX

nguyenkims commented 2 years ago

@holequantum we'll make sure to add offline support in our android v2.