simple-login / simplelogin-postfix-docker

The missing Docker image for SimpleLogin Postfix
https://hub.docker.com/r/simplelogin/postfix
GNU General Public License v3.0
22 stars 21 forks source link

Support SMTP Port / spamhaus DQS / main.cf generation #31

Closed BJReplay closed 8 months ago

BJReplay commented 8 months ago

Three key changes:

Removed changes PEP 668 Externally Managed which prevented Dockerfile build - no longer required after including changes for PR#32

Tested on v4.6.5beta

rehanone commented 8 months ago

@BJReplay , thanks for the PR! Can you please rebase and squash the commits. Also please confirm that these changes are tested and working.

BJReplay commented 8 months ago

Can confirm tested and working. Will do.

BJReplay commented 8 months ago

I am unskilled in git - if I rebase and squash, I still end up showing my repo with even more commits ahead of this (git appears to create a new fork for the rebase, create a new commit, and throw away the temporary fork - but as I say, I am unskilled). And, the changes for https://github.com/simple-login/simplelogin-postfix-docker/pull/32 cause a conflict.

I will re-test to see if the change to deal with PEP 668 is still required, and probably close, and re-open with a cleaner version.