search

simple-repository / simple-repository-server

A tool for running a PEP-503 simple Python package repository, including features such as dist metadata (PEP-658) and JSON API (PEP-691)
MIT License
20 stars 1 forks source link

etags should be in double quotes #2

Closed bewinsnw closed 3 months ago

bewinsnw commented 4 months ago

minor nit: https://github.com/simple-repository/simple-repository-server/blob/fe353669c64ca77ef9621d377bb728a13e6c33ae/simple_repository_server/routers/simple.py#L135

See the spec: https://www.rfc-editor.org/rfc/rfc9110#field.etag

I've literally once, ever, seen this be an issue, with virgin media's web-to-cable-tv caches back in 2001. But that client just dropped responses with misformatted etags on the floor.

pelson commented 3 months ago

Turns out this was a problem with starlette too... recently fixed (https://github.com/encode/starlette/issues/2298#issuecomment-1793391343).

This will be fixed in >v0.5.0 (and >0.5.0 of simple-repository core also)

pelson commented 3 months ago

Fixed in v0.6.0. Thanks for the nit - it is always good to improve this stuff.

pelson commented 3 months ago

Note that it is also necessary to update simple-repository at the same time (to v0.7.0) to have local files have correct etags.