search

simple-xmpp / node-simple-xmpp

Simple High Level NodeJS XMPP Client
301 stars 90 forks source link

Make some of the internals available outside so that it's easy to extend #1

Closed rakeshpai closed 13 years ago

rakeshpai commented 13 years ago

Exposed some of the underlying guts out so that it's possible to extend externally. The changes are backwards-compatible.

arunoda commented 13 years ago

merged.

On Thu, Sep 8, 2011 at 2:24 PM, Rakesh Pai < reply@reply.github.com>wrote:

Exposed some of the underlying guts out so that it's possible to extend externally. The changes are backwards-compatible.

You can merge this Pull Request by running:

git pull https://github.com/rakeshpai/node-simple-xmpp patch-1

Or you can view, comment on it, or merge it online at:

https://github.com/arunoda/node-simple-xmpp/pull/1

-- Commit Summary --

  • Exposed some of the underlying guts out so that it's possible to extend externally. The changes are backwards-compatible.

-- File Changes --

M lib/simple-xmpp.js (5)

-- Patch Links --

https://github.com/arunoda/node-simple-xmpp/pull/1.patch https://github.com/arunoda/node-simple-xmpp/pull/1.diff

Reply to this email directly or view it on GitHub: https://github.com/arunoda/node-simple-xmpp/pull/1

Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda

rakeshpai commented 13 years ago

Awesome! I'm new to this Github thing, but I need your project. I'll give you another push request or two, if you don't mind - I'd rather have you maintain one definitive source rather than fork unnecessarily. However you might disagree with me in philosophy in terms of API and ease of use. i'll let you decide that. Expect more push requests from me, and it's totally ok if you reject them. :)

arunoda commented 13 years ago

Github thing is fork fork and do pull requests. :-) You are totally welcome.

On Friday, September 9, 2011, Rakesh Pai < reply@reply.github.com> wrote:

Awesome! I'm new to this Github thing, but I need your project. I'll give you another push request or two, if you don't mind - I'd rather have you maintain one definitive source rather than fork unnecessarily. However you might disagree with me in philosophy in terms of API and ease of use. i'll let you decide that. Expect more push requests from me, and it's totally ok if you reject them. :)

Reply to this email directly or view it on GitHub: https://github.com/arunoda/node-simple-xmpp/pull/1#issuecomment-2043843

Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda