search

simple-xmpp / node-simple-xmpp

Simple High Level NodeJS XMPP Client
301 stars 90 forks source link

query.attrs undefined - line 331 #29

Closed silverbucket closed 11 years ago

silverbucket commented 11 years ago

Hi @Daniel15 a pull request you submitted a while back is causing an error in the library. Could you patch this? Seems simple enough, but I'm not sure what it means if the query variable is unset as in this case, what would be the correct course of action.

simple-xmpp/lib/simple-xmpp.js:331
    node = query.attrs.node,
                ^
TypeError: Cannot read property 'attrs' of undefined
silverbucket commented 11 years ago

Pull request #14

silverbucket commented 11 years ago

originally reported by @michielbdejong

michielbdejong commented 11 years ago

yeah, i'm getting this by simply running the example code from the readme. will try to find more info.

Daniel15 commented 11 years ago

I'll try to take a look tonight if I get some free time. I believe this was an issue that I fixed in junction-caps ( https://github.com/Daniel15/junction-caps) but must have forgotten to fix in the simple-xmpp implementation.

Regards, Daniel Lo Nigro http://dan.cx/ | http://twitter.com/Daniel15

On Wed, May 29, 2013 at 3:42 PM, Michiel@unhosted notifications@github.comwrote:

yeah, i'm getting this by simply running the example code from the readme. will try to find more info.

— Reply to this email directly or view it on GitHubhttps://github.com/simple-xmpp/node-simple-xmpp/issues/29#issuecomment-18597191 .