simple-xmpp / node-simple-xmpp

Simple High Level NodeJS XMPP Client
302 stars 90 forks source link

xmpp disconnect and dont reconnect even if the reconnect attribute is set to true #54

Closed Mo33n closed 6 years ago

Mo33n commented 9 years ago

File name : .\node_modules\simple-xmpp\node_modules\node-xmpp\node_modules\node-xmpp-client\node_modules\node-xmpp-core\lib\connection.js

method "onClose()" : "self.reconnect" and this.reconnect" are undefine.

dont know why. I have fixed this issue on my local setup. by passing the reconnect variable and the connect method as an argument from node_modules\simple-xmpp\node_modules\node-xmpp\node_modules\node-xmpp-client\lib\session.js file.

rosslazer commented 7 years ago

@Mo33n Would you mind sharing you fix in a gist? I'm having a similar issue. It usually reconnects, but after 24 hours or so it stops.

Mo33n commented 7 years ago

@rosslazer that was very old patch , may be the library owner has fixed that issue, you goto check with him .

what i was doing is passing "reconnect = true" flag in the _socketConnectionToHost method inside \simple-xmpp\node_modules\node-xmpp-client\lib\session.js

rosslazer commented 6 years ago

Where is the PR that fixes this?

On Thu, Sep 14, 2017 at 7:04 AM, Moeen Mohsin notifications@github.com wrote:

Closed #54 https://github.com/simple-xmpp/node-simple-xmpp/issues/54.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/simple-xmpp/node-simple-xmpp/issues/54#event-1249278270, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv2FoVVDsJaZv-3aw90_FJZHzmH2KdJks5siTIogaJpZM4DQWEI .

Mo33n commented 6 years ago

dont know, but this case is not reproducing with the latest code.