search

simple-xmpp / node-simple-xmpp

Simple High Level NodeJS XMPP Client
301 stars 90 forks source link

Enabled multiple xmpp connections #6

Closed soggie closed 12 years ago

soggie commented 12 years ago
tttp commented 12 years ago

Hi

I have forked off the @jolira branch, that has implemented this change (and a few others that made sense in my context).

@soggie you have put in your merge a change in the documentation that isn't related to the multiple connections issue, might be better if you split them?

I haven't used it, but I think simple-xmpp (or the underlying module?) handles directly oAuth, so you don't have to handle manually the session if you give the constructor the tokens instead of the login+pwd credential.

Have seen an example, can't put my hand on it right now

arunoda commented 12 years ago

@soggie I like the way how we can export the underline SimpleXMPP class.

Can you please add how to create a multiple simple XMPP connections? And please remove the facebook guide in this pull request.

Send fb one as a another pull.

I will merge both.

soggie commented 12 years ago

I AM ON IT!!!!! >:-O BURNING!

arunoda commented 12 years ago

:)

On Thu, Aug 9, 2012 at 3:16 PM, Ruben Tan Long Zheng < notifications@github.com> wrote:

I AM ON IT!!!!! >:-O BURNING!

— Reply to this email directly or view it on GitHubhttps://github.com/arunoda/node-simple-xmpp/pull/6#issuecomment-7609820.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda

soggie commented 12 years ago

^ let me know if this is good enough. We could add more guides later.

arunoda commented 12 years ago

Yes this is great. I 'll at merge this. I'll add make a release tonight with this.

tttp commented 12 years ago

Thanks.

I'll rebase to this branch and probably pull a few new stuff for your consideration

arunoda commented 12 years ago

awesome. Thanks for you :)

arunoda commented 12 years ago

@soggie Thanks for your contribution :)

soggie commented 12 years ago

No problem. You're helping me too, since I'm using this module for my stuff. Might help with test cases and travis integration once I get enough time.

arunoda commented 12 years ago

great.

On Thu, Aug 9, 2012 at 8:58 PM, Ruben Tan Long Zheng < notifications@github.com> wrote:

No problem. You're helping me too, since I'm using this module for my stuff. Might help with test cases and travis integration once I get enough time.

— Reply to this email directly or view it on GitHubhttps://github.com/arunoda/node-simple-xmpp/pull/6#issuecomment-7617345.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda