search

simple-xmpp / node-simple-xmpp

Simple High Level NodeJS XMPP Client
302 stars 90 forks source link

FIX: the "chat" event should return the full "stanza.attrs.from" string #86

Closed le-yak closed 4 years ago

le-yak commented 5 years ago

The "from" parameter returned by the "chat" event contains only the room name, not the actual sender. This is not what the README says, and is not consistent with other events, e.g. groupchat. This changed during commit 45547133c7d6a19e6532feb6eb9d2b70e0d2e715, and looks like a debug code left by mistake.

Possibly answers #82.

le-yak commented 4 years ago

Brain fart, sorry for the trouble. The change was actually made during bac143351a75c98ee7fb888bbbb2da3d3adadaa2, and the code is compliant.