search

simpleanalytics / astro-plugin

ISC License
3 stars 0 forks source link

Installation fails with npm #1

Open tambuildsthings opened 1 week ago

tambuildsthings commented 1 week ago

Astro Simple Analytics Plugin: Bug report

Describe the bug

Installing with npm doesn't complete.

Terminal output shows: 4 vulnerabilities (1 low, 1 moderate, 2 high)

To Reproduce

Steps to reproduce the behavior:

  1. Have an Astro project
  2. In your terminal do npm install astro-simpleanalytics-plugin
  3. See error
  4. Cannot build site nor use Simple Analytics due to incomplete installation

Expected behavior

Installation completes and enables use of Simple Analytics

Additional context

Workaround is to just paste in the boilerplate code directly into your Layout file.

ViorelMocanu commented 1 week ago

@tambuildsthings the error I get when replicating your steps is:

added 17 packages, changed 1 package, and audited 419 packages in 4s

163 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (1 low, 1 moderate, 2 high)

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

This is a security issue which should be solved today, I updated the downstream dependencies for this and fixed the security warnings. It now reads:

added 1 package, and audited 404 packages in 1s

157 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Please let me know if this fixes things for you too.

Optionally, @adriaandotcom not sure if I can update the current plugin codebase with the latest version from https://github.com/ViorelMocanu/astro-simpleanalytics-plugin - would you be able to help?

adriaandotcom commented 1 week ago

Can we somehow make that the official plugin?

ViorelMocanu commented 1 week ago

Can we somehow make that the official plugin?

Sure! How do you suggest we do that?

adriaandotcom commented 1 week ago

I can give you access to simpleanalytics/astro-plugin and you can overwrite this repo with your code? Making you the official maintainer of this repo. If you want to handle that responsibility :) Seems an easy task compared to how much you already have done.

It comes with a free Simple plan which renews for free when maintaining this repo.

ViorelMocanu commented 5 days ago

I can give you access to simpleanalytics/astro-plugin and you can overwrite this repo with your code? Making you the official maintainer of this repo. If you want to handle that responsibility :) Seems an easy task compared to how much you already have done.

It comes with a free Simple plan which renews for free when maintaining this repo.

Sounds great, Adriaan! Thanks.

tambuildsthings commented 5 days ago

Love it. I'll wait for the switcheroo then try the newly official plugin :)

On Wed, 20 Nov 2024 at 12:51, Viorel Mocanu @.***> wrote:

I can give you access to simpleanalytics/astro-plugin and you can overwrite this repo with your code? Making you the official maintainer of this repo. If you want to handle that responsibility :) Seems an easy task compared to how much you already have done.

It comes with a free Simple plan which renews for free when maintaining this repo.

Sounds great, Adriaan! Thanks.

— Reply to this email directly, view it on GitHub https://github.com/simpleanalytics/astro-plugin/issues/1#issuecomment-2488381486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2GVKW53IVLODAWWB6MUNT2BRZV7AVCNFSM6AAAAABRZI7Y3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYGM4DCNBYGY . You are receiving this because you were mentioned.Message ID: @.***>