search

simpleanalytics / roadmap

File you bugs and feature requests here
23 stars 2 forks source link

When searching the "compare filter" toggle is not updating the graph #526

Closed adriaandotcom closed 3 years ago

adriaandotcom commented 3 years ago

You would expect the chart to update based on the query as well. Can we add that?

image

jibsaramnim commented 3 years ago

@adriaanvanrossum that's already happening actually, but I think there's an issue with the Compare filtered checkbox not working correctly (It seems like it's not actually hiding the unfiltered graph anymore). When I check on my end when entering a search query I do see the graph update -- could you do me a favor and check on your end to see if this matches with what you're seeing?

adriaandotcom commented 3 years ago

You are right, it's indeed an issue with compare filtered. When you hover over the chart you indeed see the numbers for the filtered stuff.

jibsaramnim commented 3 years ago

Thanks for confirming Adriaan! We've got a PR with fix pending review and deploy! :)