SC-4183 convertMathExpressionToTeXNode does not keep parentheses

edhom commented 3 years ago

Description

Adds parentheses for binary operators, when converting a math_expression to a tex ast. Adds special cases for pi and e when converting a math_expression to a tex ast. Removes the leading zero from an unary minus when converting tex into a math_expression.

Related issues & PRs

https://simpleclub.atlassian.net/browse/SC-4183

Checklist

Remove If [...] items that do not apply to your PR.

[x] I have made myself familiar with the CaTeX contributing guide.
[x] I added a PR description.
[x] I linked all related issues and PRs I could find (no links if there are none).
[x] If this PR changes anything about the main math_keyboard or example package (also README etc.), I created an entry in CHANGELOG.md (## UPCOMING RELEASE if the change on its own is not worth an update).
[x] If this PR includes a notable change in the math_keyboard package, I updated the version according to Dart's semantic versioning.
[x] If there is new functionality in code, I added tests covering all my additions.
[x] All required checks pass.

creativecreatorormaybenot commented 3 years ago

@edhom Tests seem to be failing (on all channels).

creativecreatorormaybenot commented 3 years ago

Maybe we can also include test cases for the parentheses and unary minus :)

edhom commented 3 years ago

@creativecreatorormaybenot I'm not allowed to merge😭

creativecreatorormaybenot commented 3 years ago

@edhom Are you not able to merge now? (now that all checks have passed and there is an approval)

edhom commented 3 years ago

@creativecreatorormaybenot No I'm not authorized:D

simpleclub / math_keyboard