Cursor update SC-4607 - Githubissues

millerovv commented 2 years ago

Description

Use an updated version of flutter_math_fork 0.6.2 that introduces CursorNode and \cursor function
Replace Cursor implementation via | symbol with \cursor
Updated empty field offset dx from -4 to -1, since \cursor has smaller horizontal paddings

[x] I have made myself familiar with the CaTeX contributing guide.
[x] I added a PR description.
[x] I linked all related issues and PRs I could find (no links if there are none).
[x] If this PR changes anything about the main math_keyboard or example package (also README etc.), I created an entry in CHANGELOG.md (## UPCOMING RELEASE if the change on its own is not worth an update).
[x] If this PR includes a notable change in the math_keyboard package, I updated the version according to Dart's semantic versioning.
[x] If there is new functionality in code, I added tests covering all my additions.
[x] All required checks pass.

millerovv commented 2 years ago

Regarding the analysis checks failing on Flutter beta. This is fine (unavoidable) for now since we want to keep supporting the stable channel

Hi @creativecreatorormaybenot Yeah right, no way to fix those unfortunately. Can we somehow merge this one skipping the checks?

upd: @edhom said he also can't force merge this

creativecreatorormaybenot commented 2 years ago

@millerovv The merge was not possible as we required commits to be signed. I changed that, so now the merge should be possible anyway.

This should be fine since GitHub will sign the squash commit.

millerovv commented 2 years ago

This should be fine since GitHub will sign the squash commit.

Oh, didn't notice this and signed the squashed commits myself :\