simpleclub / math_keyboard

Math expression editing using an on-screen software keyboard or physical keyboard input in a typeset input field in Flutter.
https://simpleclub.github.io/math_keyboard
BSD 3-Clause "New" or "Revised" License
134 stars 50 forks source link

Close keyboard on hardware back press #56

Closed millerovv closed 1 year ago

millerovv commented 1 year ago

Description

https://github.com/simpleclub/math_keyboard/assets/31796433/937f0434-4034-465a-9756-8f821017b649

Related issues & PRs

https://simpleclub.atlassian.net/browse/SC-10050

Checklist

Remove If [...] items that do not apply to your PR.

tomkuschka commented 1 year ago

@millerovv The dismiss animation is not triggered when I hardware back is pressed ☹️ Since the animation happens on when the return key is pressed, I think we should also play it here

millerovv commented 1 year ago

@tomkuschka The closing animation is now working:

https://github.com/simpleclub/math_keyboard/assets/31796433/5e1b466d-7794-4986-806f-4c08c4e39304

codecov-commenter commented 1 year ago

Codecov Report

Merging #56 (7180251) into main (f586c6b) will decrease coverage by 0.34%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   27.44%   27.11%   -0.34%     
==========================================
  Files          11       11              
  Lines        1133     1147      +14     
==========================================
  Hits          311      311              
- Misses        822      836      +14     
Flag Coverage Δ
math_keyboard 27.11% <0.00%> (-0.34%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
math_keyboard/lib/src/widgets/math_field.dart 0.00% <0.00%> (ø)