simplefoc / Arduino-FOC

Arduino FOC for BLDC and Stepper motors - Arduino Based Field Oriented Control Algorithm Library
https://docs.simplefoc.com
MIT License
1.95k stars 511 forks source link

renesas: disable capture interrupt before open() #322

Closed facchinm closed 9 months ago

facchinm commented 9 months ago

Fixes https://github.com/arduino/ArduinoCore-renesas/issues/139

Renesas fsp structures must be properly initialized entirely since memsetting all to 0 makes some values "valid" (in this case, the capture irq was firing as 0 instead than the agt interrupt, leading to a null pointer crash)

runger1101001 commented 9 months ago

Thank you so much for this! It makes complete sense.

What I don't understand is why only the WiFi was affected, an not the Minima.

I will merge to our dev branch and test it.

runger1101001 commented 9 months ago

Thanks @facchinm ❤️ this has indeed fixed the problem.

runger1101001 commented 9 months ago

https://github.com/arduino/ArduinoCore-renesas/issues/139 could be closed but I am still blocked from commenting on it / closing it