simplefoc / Arduino-FOC

Arduino FOC for BLDC and Stepper motors - Arduino Based Field Oriented Control Algorithm Library
https://docs.simplefoc.com
MIT License
1.94k stars 510 forks source link

Support for the new ESP32 LEDC library API #390

Open flowersauce opened 3 months ago

flowersauce commented 3 months ago

In the arduino-ESP32 v3.0.0, there have been changes to the LEDC library API. I kindly request your support in updating the simpleFOC library to accommodate these changes. fb581440deef4f81d286f67641f8f9f6 https://docs.espressif.com/projects/arduino-esp32/en/latest/migration_guides/2.x_to_3.0.html

askuric commented 3 months ago

Ok, the time is come, the v3.0.0 is released officially. :)

This release introduces a lot of braking changes. It will be our priority for the next release, but as there will be one release coming very soon 2.3.3. this will probably not be a part of it. However, in the next few weeks you should have it supported in the dev branch at least

askuric commented 3 months ago

I'd like to keep this issue open until we actually do support the v3.0.0!

runger1101001 commented 3 months ago

It seems to me its still an alpha release?

It hasn't made it into the regular esp32 support of PlatformIO yet either. It was a bit of a pain to get it working, but after finding the right URL for the tasmota version of the framework I have PlatformIO compiling and running code on ESP32-C6 :-)

As far as I am aware Arduino IDE users also still have to reference the dev version of the boards manager URL?

So while I completely agree that we need to work on the support for it, and soon, I think we have to choose the moment to merge it to the main release carefully, so as not to break compatibility for a lot of users.