Closed bigglesrocks closed 11 years ago
I think someone raised this same issue on the Roots original theme, and there's supposedly a way to do that now. I'll look into it and put this on the next batch of updates to Base.
I actually made it work for Riverfest after I submitted the issue, I just didn't know how to fork or pull request or anything last night.
Jessica Biggs
On Jan 30, 2013, at 9:08 AM, cjmox notifications@github.com wrote:
I think someone raised this same issue on the Roots original theme, and there's supposedly a way to do that now. I'll look into it and put this on the next batch of updates to Base.
— Reply to this email directly or view it on GitHub.
Currently the function used to specify which pages and page templates show the default sidebar in config.php uses Wordpress's is_page_template() function to check the values in the page templates array. Templates for custom post types cannot be passed to the roots_display_sidebar function through the second array because of this.
In order to keep the code organized, some way to pass custom post types or custom post type templates to that function via a third array or changing the function used to check the second array would be ideal rather that adding conditionals to sidebar.php.