simpleidserver / SimpleIdServer

OpenID, OAuth 2.0, SCIM2.0, UMA2.0, FAPI, CIBA & OPENBANKING Framework for ASP.NET Core
https://simpleidserver.com/
Apache License 2.0
716 stars 94 forks source link

[SCIM] PATCH replace operation remove others properties #715

Closed gabrielemilan closed 3 months ago

gabrielemilan commented 6 months ago

Hello, it seems there is a regression in the replace operation.

image

Some arrays have been deleted.

Can you please check? Regards.

simpleidserver commented 6 months ago

Hello,

Due to performance issues, we have made some modifications to the SimpleIdServer.Scim package. Now, it does not return the entire object or representation in the response to an HTTP PATCH or PUT request.

There are scenarios where a user can be assigned to more than one million groups. In such situations, we do not wish to return the full representation.

Could you please check if the representation is correct when you execute an HTTP GET?

If you prefer, we can add a new property, IsFullRepresentationReturned, in the options. This property would enable returning the full representation in the response when set to true.

Best regards,

SID

gabrielemilan commented 6 months ago

Yes please, it can be a good solution.

Thanks

simpleidserver commented 6 months ago

The 'IsFullRepresentationReturned' property has been added to the options. When this property is set to true, the full representation will be returned.

gabrielemilan commented 6 months ago

The 'IsFullRepresentationReturned' property has been added to the options. When this property is set to true, the full representation will be returned.

Ok thanks, is it the version already published?

simpleidserver commented 6 months ago

The version has not yet been published. I will release a pre-release version next week.

simpleidserver commented 6 months ago

The NuGet package 4.0.8-rc1 has been published. You can set the property IsFullRepresentationReturned to true in order to return the complete representation after the update operation.

gabrielemilan commented 6 months ago

The NuGet package 4.0.8-rc1 has been published. You can set the property IsFullRepresentationReturned to true in order to return the complete representation after the update operation.

thank you very much