search

simpleinjector / Documentation

Documentation for Simple Injector in reStructureText
20 stars 55 forks source link

Show where IMediator is coming from #133

Closed Bouke closed 1 year ago

Bouke commented 1 year ago

It wasn't immediately clear that the example is implementing the third-party MediatR.IMediator interface.

dotnetjunkie commented 1 year ago

This documentation page actually doesn't refer to the third-party MediatR library. Half way the document, the IMediator interface is defined. Very likely, the interface defined on this page is different from that defined by MediatR.

dotnetjunkie commented 1 year ago

Might be useful, though, to add a comment in first code sample that notes that the IMediator interface is defined below.

Bouke commented 1 year ago

I was just coming back to this PR to retract it, as indeed it is sitting just there. My bad. I got confused reading about MediatR; we already do CQRS but not through MediatR, so I skipped some parts. I guess it becomes clearer to me now. Sorry for the bother.

dotnetjunkie commented 1 year ago

I'll add a comment, because it is likely more developers will trip over this.