search

simpleledger / slp-specifications

Simple Ledger Protocol (SLP) Specifications
MIT License
57 stars 40 forks source link

considerations for extending MINT for updating token metadata #11

Closed jcramer closed 5 years ago

jcramer commented 5 years ago

Multiple users have requested that token details can be updated after GENESIS. I think that we could possible allow this without making change to the type 0x01 DAG validator.

If we append the token details to the end of the MINT message then these fields can be either provided or omitted (not even requiring a 0x4c00 null identified).

It would simply be specified that any metadata updated in a MINT transactions Shall be considered to be the most recent metadata.

EDIT

The only Genesis metadata considering update would be documentURI and documentSha256.

markblundeberg commented 5 years ago

I guess one concern I have is -- how do DAG validators find the new metadata if they've not inherited from one of those newly minted tokens?

Additionally, I believe that current SLP implementations would see these extra pushes and deem the message to be invalid SLP, thus burning the baton: https://github.com/simpleledger/Electron-Cash-SLP/blob/713ebeee814d8adfcddacda11b2666e86fe268c9/lib/slp.py#L174-L176

fyookball commented 5 years ago

I think this is insufficient reason to modify the SLP protocol version 1. As we discussed on telegram, the data fields are immutable for a reason and you can always reissue if you make a mistake. So I would vote not to make this change.