search

simpleledger / slp-specifications

Simple Ledger Protocol (SLP) Specifications
MIT License
58 stars 40 forks source link

bitcoinfiles: Be explicit about protocol limits #36

Closed dagurval closed 3 years ago

dagurval commented 3 years ago

Specifiy which protocol limits affect the design of the bfp_message_type 0x02.

I had forgotten about the 1650 bytes per input limit, so it took me a while to figure out why the script limited itself to two pushes in the unlocking script. I think it would be helpful for others if these limits were specified.

dagurval commented 3 years ago

What do you think about this @DesWurstes ?

jcramer commented 3 years ago

The spec update changes more than providing more detail on limits. Please include the rationale for the hash verification update in the PR description.

I'll wait for @DesWurstes to ACK before my review.

dagurval commented 3 years ago

Updated PR description. I can also remove the typo fix if preferred.

jcramer commented 3 years ago

I can also remove the typo fix if preferred.

Yes, that would be awesome.

dagurval commented 3 years ago

Re-added typo and updated PR description :-)

DesWurstes commented 3 years ago

Hello,

This can be merged. I'll open a Pull Request and tune this further (and fix that typo) with what I learned from implementing it soon.