search

simplereach / sranalytics_wordpress

www.simplereach.com
1 stars 2 forks source link

Refactoring in order to be WordPress VIP ready #10

Closed andremalan closed 10 years ago

andremalan commented 10 years ago

@pnts @elubow fully tested on 4.0.0-beta 2. I think I hit all the different requirements on the VIP list as well. Also tested on 3.5.1 Let me know what you think.

elubow commented 10 years ago

Looks good to me. Is all the i18n work done here?

andremalan commented 10 years ago

It should be i18n ready now. All strings that get outputted to the admin screen are wrapped, and we load a mo-file if it exists and if the language is specified. Not sure if we need to make an actual translation file to test it though.

elubow commented 10 years ago

@andremalan Please change all the version constants to 0.1.0 and then merge.