search

simplereach / sranalytics_wordpress

www.simplereach.com
1 stars 2 forks source link

JS data is escaped twice #12

Open pdufour opened 9 years ago

pdufour commented 9 years ago

Single quotes should be displayed as \', but instead it adds two slashes.

Example: http://www.brit.co/baby-names/

<script type='text/javascript'>
    var sranalytics = {
        "version": "0.1.3",
        ....
        "authors": ["Annie D\\'Souza"]
    };
</script>
pdufour commented 9 years ago

I'm pretty sure you can remove all the esc_js calls here: https://github.com/simplereach/sranalytics_wordpress/blob/master/sranalytics.php#L162 since the data is already being json_encoded.

pdufour commented 9 years ago

bump

andremalan commented 8 years ago

Hey, we added the extra escapes based on feedback from WordPress during their WordPress.com VIP approval process.