search

simplerezo / freebsd-ports-php-vintages

Patch your Ports tree for (removed) PHP56 support
MIT License
9 stars 2 forks source link

cleanup of MOVED is necessary #2

Closed victor-sudakov closed 3 years ago

victor-sudakov commented 3 years ago

You should consider running something like

sed -e '/php56/d' -i .bak ports/MOVED

from your script to delete any lines mentioning "php56". Otherwise build produces very weird results: some modules are built as php72 modules and others fail.

clementmoulin commented 3 years ago

I don't have similar issue.

This is probably more related about the other issue you reported (patch failure).

victor-sudakov commented 3 years ago

Hello!

I don't see why you classified it as invalid, because after running your script on the ports tree (see bold text):

poudriere bulk -j 122amd64 -p php72 -z oldphp72 lang/php72-extensions [00:00:00] Creating the reference jail... done [00:00:01] Mounting system devices for 122amd64-php72-oldphp72 [00:00:01] Converting package repository to new format [00:00:01] Stashing existing package repository [00:00:01] Mounting ports from: /poudriere/ports/php72 [00:00:01] Mounting packages from: /poudriere/data/packages/122amd64-php72-oldphp72 [00:00:01] Mounting distfiles from: /usr/ports/distfiles [00:00:01] Copying /var/db/ports from: /usr/local/etc/poudriere.d/php72-oldphp72-options [00:00:01] Appending to make.conf: /usr/local/etc/poudriere.d/make.conf /etc/resolv.conf -> /poudriere/data/.m/122amd64-php72-oldphp72/ref/etc/resolv.conf [00:00:01] Starting jail 122amd64-php72-oldphp72 [00:00:02] Logs: /poudriere/data/logs/bulk/122amd64-php72-oldphp72/2021-06-07_17h43m19s [00:00:02] Loading MOVED for /poudriere/data/.m/122amd64-php72-oldphp72/ref/usr/ports [00:00:08] Ports supports: FLAVORS SELECTED_OPTIONS [00:00:08] Gathering ports metadata [00:00:08] Warning: MOVED: lang/php72-extensions renamed to lang/php74-extensions [00:00:10] Calculating ports order and dependencies

which is of course not desired.

clementmoulin commented 3 years ago

Well, this cause issue when using poudriere. If you make a PR I would consider it, but for now this project is a "dirty-hack" and not expected to work with poudriere.

victor-sudakov commented 3 years ago

If you make a PR I would consider it, but for now this project is a "dirty-hack" and not expected to work with poudriere.

It may be enough to add rm -f ${DIR_PORTS}/MOVED to the beginning of your script. Quite in the spirit of a dirty hack :-)