search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

&qout? #14

Closed flowardnut closed 9 years ago

flowardnut commented 9 years ago

Why are you using &qout and not &quot?

(SAMLTrace.js) function xmlEntities(string) { string = string.replace('&', '&', 'g'); string = string.replace('"', '&qout;', 'g'); string = string.replace("'", ''', 'g'); string = string.replace('<', '<', 'g'); string = string.replace('>', '>', 'g'); return string; }

olavmrk commented 9 years ago

That would be a bug. Few people have quotes in attribute values and text nodes in SAML-messages, so it hasn't been noticed before.

Thanks for letting us know. I will commit a fix for it.