search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

multiple POST variables with same name only appear once #29

Closed martinhaase closed 6 years ago

martinhaase commented 6 years ago

Doing a POST, looking at the variables for a checkbox with multiple values. Expecting:

consent: read consent: write

However, SAML Tracer shows only one of them. I have not checked whether this affects also GET query parameters.

khlr commented 6 years ago

Hi Martin!

You're right, that's a bug (POST-only, GET works). My bad... I didn't correctly convert the function parsePOST.

For anyone interested: You can reproduce this using the following two JSFiddles (checking "coding" and "music"):

GET (https://jsfiddle.net/p7sfp61r/1/) produces:

GET
interest: coding 
interest: music 
other:

POST (https://jsfiddle.net/p7sfp61r/) produces:

POST
interest: coding 
other:
khlr commented 6 years ago

I just fixed it in pull request #30.

martinhaase commented 6 years ago

Thanks Jan for the quick response! Good stuff!