search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

Feature/gh 25 export function #32

Closed khlr closed 6 years ago

khlr commented 6 years ago

This is the pull request for issue #25, bringing back the export and import functionality. As with the last PRs: I'd be glad if someone could do a review :-)

thijskh commented 6 years ago

Great! I did two initial tests with two completely different SAML flows, and both export fine but the import of the just exported file in both cases yields "Error while importing: InvalidCharacterError: String contains an invalid character".

I can email you the output if that's useful.

I can look into more detail later.

khlr commented 6 years ago

Yep, it'd be very interesting to have a look at your exports! I've tested on both Windows and Linux but didn't experience this result.

Could you take my email address from the commit history and send the exports to me? Thank you!

thijskh commented 6 years ago

I have sent you two samples.

khlr commented 6 years ago

I didn't take into account that SAMLResponses may not be re-constructible if the POST-array was obfuscated or removed during the preceding export.

Thanks for the samples, @thijskh. And thank you very much (!) for the moo-archive test-account, @tvdijen! It really helped me a lot with this 👍

thijskh commented 6 years ago

Good, im-/export works robustly now!