simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

Issues with current version #33

Closed RandomGuy26 closed 6 years ago

RandomGuy26 commented 6 years ago

Since the latest version was released, it doesn't appear to be working with any version of FireFox that I've found. One workaround that had work was to use FireFox ESR, but then that too quit working.

Anyone seeing this problem? Is there a workaround?

khlr commented 6 years ago

Hi!

Which Firefox versions did you try? Do you use Windows or Linux?

RandomGuy26 commented 6 years ago

Windows 7

Current version I tried was ESR 52.5.3, tried the version before it as well. Also used 32-bit FireFox 56.0 and SAML 0.4.0 but letting it update to 1 breaks it.

Sent from my iPhone

On Jan 18, 2018, at 1:40 PM, Jan Köhler notifications@github.com<mailto:notifications@github.com> wrote:

Hi!

Which Firefox versions did you try? Do you use Windows or Linux?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UNINETT/SAML-tracer/issues/33#issuecomment-358756258, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7bdYomRv9fGqjbkQi45HXUPnD1evS9ks5tL5wNgaJpZM4Rjaf0.

Bigfoot0007 commented 6 years ago

52.5.3 (32-bit), can 't work now.

RandomGuy26 commented 6 years ago

Right I have tried MANY versions of FireFox I can't recall them all.

Is there a version of Firefox where SAML Tracer 1 works with? Maybe that's a better approach to the issue.

Sent from my iPhone

On Jan 19, 2018, at 7:36 AM, Lyndon notifications@github.com<mailto:notifications@github.com> wrote:

52.5.3 (32-bit), can 't work now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UNINETT/SAML-tracer/issues/33#issuecomment-358967776, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7bdVh7_rCLraLRjJDfmmsZkefNERLUks5tMJpngaJpZM4Rjaf0.

thijskh commented 6 years ago

I've just reïnstalled SAML Tracer 1.0 from addons.mozilla.org from scratch on FF 57.0.4 on Linux and that just works. Only thing is the known (FF) bug that the window is initially blank unless you right-click it.

Perhaps it helps if you describe what doesn't work exactly or how it fails.

RandomGuy26 commented 6 years ago

FF ESR 52.5.3 64-bit the right clicking on the window did not work, I will try to find a 57 version.

Sent from my iPhone

On Jan 19, 2018, at 8:26 AM, Thijs Kinkhorst notifications@github.com<mailto:notifications@github.com> wrote:

I've just reïnstalled SAML Tracer 1.0 from addons.mozilla.orghttp://addons.mozilla.org from scratch on FF 57.0.4 on Linux and that just works. Only thing is the known (FF) bug that the window is initially blank unless you right-click it.

Perhaps it helps if you describe what doesn't work exactly or how it fails.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UNINETT/SAML-tracer/issues/33#issuecomment-358979963, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7bdZTVTN2MdImtH8bw8wVvETwvQCyRks5tMKYDgaJpZM4Rjaf0.

khlr commented 6 years ago

First of all: Any SAML Tracer version before v1.0 won't work from FF57 onwards, since the support for XPCOM/XUL-based extensions was dropped with that FF-version.

Consequently, with v1.0 SAML Tracer has been converted from a XUL-based extension to a WebExtension. This type of extension will be compatible from FF57 onwards, but may not be compatible with older FF-versions (depending on whether the respective FF-version already implemented the follwing JavaScript APIs or not):

SAML Tracer v1.0+ uses the following JavaScript APIs:

As you can see, most APIs are available since FF45, onBeforeRequest came with FF46. So in theory that should be the absolute minimum version.

--

I downloaded FF46 (32 bit) in a Windows 7 VM and installed SAML Tracer v1.0. The web extension could be installed and the icon occurs in the menu bar. But when clicking on that icon... nothing happens (as reported bei @RandomGuy26 and @Bigfoot0007).

To reveal any errors, one should open the "Browser Console" which can be opend by pressing Ctrl+Shift+J. That console shows the following error in FF46 when the SAML Tracer menu item is clicked:

Type error for parameter createData (Property "type" is unsupported by Firefox) for windows.create.

image

I cannot tell why this happens, but I think that in this case the window-API may not implement everything that's requiered (just a guess), although it should.

I tested the same thing for FF 52.2.3 ESR (32 bit). In this case SAML Tracer opens but doesn't trace any request. Again, the browser console reveals the errors. The errors shown there relate to the logic around webRequest-API. So again: My wild guess is that there isn't everything up to date with that API in FF52.

image

My last try was FF56 (32 bit). This FF-version worked without any issues with SAML Tracer v1.0 *phew* :-) Maybe there are other compatible FF-versions between FF52 and FF56 as well.

--

tl;dr

So to sum this up: If there's no reason that prevents you from upgrading to FF57 (or any newer version in the future) - upgrade to that version and use FF57+ in conjunction with SAML Tracer v1.0+.

If (for whatever reason) you cannot upgrade to FF57:

thijskh commented 6 years ago

Agreed with khlr: there's nothing wrong with SAML-Tracer 0.4 so you can just continue to use it with older browser versions. And use 1.0 and up for post-57 FF.

jaimeperez commented 6 years ago

I think @khlr summarized pretty well what versions of the SAML tracer will work with what versions of Firefox, so I'm closing the issue.

ElijahLynn commented 6 years ago

The known bug/issue with a whitescreen unless you right-click should be linked to from this issue.

thijskh commented 6 years ago

It's https://bugzilla.mozilla.org/show_bug.cgi?id=1425829 and perhaps https://bugzilla.mozilla.org/show_bug.cgi?id=1408446

thijskh commented 5 years ago

It does not happen anymore for me on FF 63