search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

Deactivate autoscroll on scroll up and reactivate when scrolled down. #38

Closed khlr closed 6 years ago

khlr commented 6 years ago

Does this sound familiar to you? You're investigating a certain request. And then - a late response drops in and the request list scrolls down to the bottom.

This pull request handles exactly this. When you scroll up, the autoscroll functionality gets disabled and re-enabled when you again scroll down to the bottom.

jaimeperez commented 6 years ago

Thanks a lot @khlr! I haven't tested it myself yet, so it might be that you have already thought about this, but... what about having a visual hint that new HTTP messages have been exchanged? Maybe even with the possibility to go straight to the bottom...

khlr commented 6 years ago

I modified the Autoscroll-button to scroll the request list down to the bottom, when the user re-enables the button.

Regarding a visual hint... At the moment I've no nice idea where to place such a hint and I'm even not quite sure if it'd be really required. You could probably notice new messages through a growing scrollbar to some extent. What do you think about this?

jaimeperez commented 6 years ago

I was thinking about the typical floating control by the bottom of the view, telling you there are new traces, and allowing you to click on it to scroll down to the end. In any case, this works perfectly fine as well 👍

Thanks a lot again!