search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
141 stars 39 forks source link

The clear-button now removes tabs #50

Closed khlr closed 5 years ago

khlr commented 5 years ago

This is a small issue but something that really bugs me for quite a while:

If you traced some requests and then hit the clear-button, the requests were removed. However, a click on one of the tabs (http, parameters, SAML) would reveal the last request:

c38f1e9d-d5a0-4194-baf1-cc443d4c14a4

After the fix, the tabs will also be removed, which means that this problem can no longer occur:

91dcd78b-5ba3-4ade-a5ed-4a58193f277d

jaimeperez commented 5 years ago

Merged as well! I have to say having a visual demonstration of the before & after is really useful when evaluating a PR. What are you using to capture your screen and creating the gifs?

khlr commented 5 years ago

Thank you, @jaimeperez!

On Windows I'm using ScreenToGif which is a really powerful and easy to use tool! On Linux I've been using Peek which is really easy to use, as well, but not as feature-rich as ScreenToGif.