simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
141 stars 39 forks source link

Show resource if filter not active #51

Closed khlr closed 5 years ago

khlr commented 5 years ago

There's a bug which leads to trace records of resources being filtered even if the Filter resources button is deactivated.

This happens because the CSS class displayAnyway isn't appended to a resource-request in the attachResponseToRequest function. Only a click on Filter resources adds the class to the resource-requests.

The correct behavior would be to add the class directly within attachResponseToRequest function if the current state of filterResources is false.


Current behavior in SAML-tracer v1.5.1 Notice the filtered requests even though the filter button is not active:

73125401-20c6-4132-a07c-191cb45037b7

This pull request corrects the behavior as shown beneath

714ef735-5785-4290-bf15-4b8e66eea19f

jaimeperez commented 5 years ago

Thanks a lot @khlr!