The function `xmlEntities` should be removed

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages

https://addons.mozilla.org/nl/firefox/addon/saml-tracer/

BSD 2-Clause "Simplified" License

141 stars 39 forks source link

The function `xmlEntities` should be removed #53

Closed khlr closed 4 years ago

khlr commented 5 years ago

This PR fixes the issues mentioned in #26 and #52.

khlr commented 5 years ago

What about merging this PR as well, @jaimeperez? Could form a nice bugfix release (e.g. 1.5.2?) :-)

jaimeperez commented 5 years ago

Hi @khlr!

Does this keep values structured as XML? I'm thinking particularly about the case where we have a NameID as an attribute's value that I was mentioning here.

khlr commented 5 years ago

You're right, we have to re-think this once again 😉 Maybe we better resume the conversation at issue #52 to not have the discussion at two places, @jaimeperez 🙂

jaimeperez commented 5 years ago

Hi @khlr!

I understand there are no pending issues here and we could merge this, right?

khlr commented 5 years ago

Exactly :-)