Wrong display/export of UTF-8 strings

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages

https://addons.mozilla.org/nl/firefox/addon/saml-tracer/

BSD 2-Clause "Simplified" License

141 stars 39 forks source link

Wrong display/export of UTF-8 strings #56

Closed durkovic closed 5 years ago

durkovic commented 5 years ago

SAML tracer does not correctly display and/or export UTF-8 strings:

<?xml version="1.0" encoding="UTF-8"?>
<saml2p:Response 
....
 <saml2:Attribute FriendlyName="displayName"
                  Name="urn:oid:2.16.840.1.113730.3.1.241"
                  NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri"
                  > 
      <saml2:AttributeValue>Marian ÄurkoviÄ</saml2:AttributeValue>
 </saml2:Attribute>

Same problem in exported .json file

khlr commented 5 years ago

Thank you for reporting this issue and sorry for the late reply. I think PR #57 should do the trick :-)

durkovic commented 5 years ago

Thanks, with your patch accented chars are displayed correctly.

jaimeperez commented 5 years ago

Thanks @durkovic for reporting this and @khlr for fixing it! I've just merged the PR 😄