simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
141 stars 39 forks source link

colorize and uncolorize items #63

Closed khlr closed 4 years ago

khlr commented 4 years ago

This pull request contains three changes:

  1. The color of requests whose responses didn't arrive yet, is set to a light grey.
  2. The bold font weight of erroneous requests is removed.
  3. There's a button to un-colorize or re-colorize all traced requests.

Let me say a few words on this subject.

Regarding 1: I often find myself quite annoyed of dozen of requests the browser issued but whose responses didn't arrive (and won't arrive anymore) since a redirect or whatever occurred in the meantime. These "response-less" requests are irrelevant but occur very noticeable because their color is a quite blackish grey. By changing their color, one pays less attention to them.

Regarding 2: Erroneous requests appear often to be missing ico-files, fonts or other irrelevant content that end up in a status code 404. Since client (400-499) and server errors (500+) appear in red color (which is very flashy) they strike the eye anyways. By removing the bold font weight, one - again - pays less attention to these almost always irrelevant requests:

image

Regarding 3: Sometimes the colorization of all traced requests can be overwhelming. Having the ability to un- and re-colorize the requests is a nice new option, I think:

image

By the way: The new icon shall depict a color drop. I hope this is recognizable. Creating an icon in these small dimensions is fairly challenging 😁