This pull request fixes two bugs which caused an incorrect hidden request count:
Requests without responses haven't been counted correctly.
"fakeRequests" led to incomprehensible counts.
Regarding 1:
This can be very easily be reproduced by accessing any arbitrary non-existent ressource. E.g. http://www.non-existent-website.com/
SAML-tracer collects the GET and displays the request. Since there'll never be a response for this request, this entry will not get the isVisible property assigned. Entries without that property are shown in the upper pane. Everything fine so far.
But unfortunately SAML-tracer counts this request as a hidden one due to the property being undefined:
Regarding 2:
The webRequest-API implementation of Firefox issues fakeRequests in some situations which should be ignored by SAML-tracer.
This can be reproduced by first opening a new tab (about:blank). Firefox may list some items with thumbnails on that new tab. E.g. some recently visited websites, recommended news and so on.
Now click on http://www.non-existent-website.com/.
The result: SAML-tracer traces the request to the non-existent website and some invisible fake requests...
jaimeperez
commented
4 years ago
This pull request fixes two bugs which caused an incorrect hidden request count:
Regarding 1: This can be very easily be reproduced by accessing any arbitrary non-existent ressource. E.g. http://www.non-existent-website.com/ SAML-tracer collects the GET and displays the request. Since there'll never be a response for this request, this entry will not get the
isVisibleproperty assigned. Entries without that property are shown in the upper pane. Everything fine so far. But unfortunately SAML-tracer counts this request as a hidden one due to the property beingundefined:Regarding 2: The webRequest-API implementation of Firefox issues fakeRequests in some situations which should be ignored by SAML-tracer. This can be reproduced by first opening a new tab (
about:blank). Firefox may list some items with thumbnails on that new tab. E.g. some recently visited websites, recommended news and so on. Now click on http://www.non-existent-website.com/. The result: SAML-tracer traces the request to the non-existent website and some invisible fake requests...