Closed amnemonic closed 2 years ago
Hi Adam!
This a really, really cool feature! I especially like the ability to download embedded certificates! This is really conveniant 🙂
There's only one thing I noticed while testing the PR. I'll leave a note at the relevant line in the js file.
Sorry that it took me so long to have a look at your PR... 🐌😁 @jaimeperez Jaime, do you think you will have a moment to look at these changes, too?
Best regards Jan
Well, I'm really sorry for taking so long to do this... 😴 But finally here is the promised data: tokens.zip
Thanks @khlr for files. It helped a lot in debugging. If you don't mind I used them in my test cases page. Attached preview of your use-cases.
@jaimeperez @khlr : kindly asking for code review and merge to master.
Really nice, Adam! Works like a charm :-) I'll leave some notes at the code.
If you don't mind I used them in my test cases page. Attached preview of your use-cases.
No, that's perfectly fine! The page is really helpful!
Hello @jaimeperez can you consider merging this PR?
Bump @khlr @jaimeperez @Uninett
I'll try to reach Uninett outside Github.. The other two persons can't help you since they don't have write permission. Perhaps @knumor can help help us to get the two open PRs merged and a new release for this module?
For the record. I have proposed that we move the SAML-Tracer under the SimpleSAMLphp Github org and UNINETT has agreed. It will take quite a few steps to realise this transfer but perhaps we should just start doing it.
Finally since last pull request I found some time to polish UI of summary tab. Also new feature: if some certificates are embedded in response then you can download them. I've only made changes inside
showSummary
function and added 3 rules tosamltrace.css
file.AuthnRequest
SamlResponse
WS-Federation sample
![ws-fed-sample](https://user-images.githubusercontent.com/29899901/96968563-6ea70900-1511-11eb-9c7a-056812a7ed08.png)