UI glitch: not all parameter keys are highlighted

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages

https://addons.mozilla.org/nl/firefox/addon/saml-tracer/

BSD 2-Clause "Simplified" License

141 stars 39 forks source link

UI glitch: not all parameter keys are highlighted #83

Closed tvdijen closed 10 months ago

tvdijen commented 1 year ago

afbeelding

I just noticed that not all parameter names are purple.

thijskh commented 1 year ago

The problem is the underscores. This display also uses the syntax highlighting from hljs with language “HTTP” which I guess is about http headers, not parsed parameters.

tvdijen commented 1 year ago

I think the properties language would be appropriate to use here

khlr commented 1 year ago

Hello Tim and Thijs!

Yep, I think you're absolutely right. The currently used language highlighting is certainly not the best choice. I probably chose that one back in the days, because it seemed appropriate to me and works in a lot of cases, but - as we see 😉 - not in all cases. The properties language really seems to be worth a try, Tim!