simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
142 stars 39 forks source link

Firefox 29 #9

Closed mrvanes closed 9 years ago

mrvanes commented 10 years ago

I can't find SAML tracer menu in revamped Firefox 29 interface anymore. Is it compatible?

mrvanes commented 10 years ago

Never mind. Just enabled the menubar, then it's available under tools.

twardmke commented 10 years ago

I am having the same problem... can you provide a little more detail on where you found SAML tracer in Firefox 29? Thanks.

mrvanes commented 10 years ago

Right-click beside that last tab, click on "Menu Bar" to enable the menu. Then it's Tools -> SAML tracer, just like old times.

twardmke commented 10 years ago

There it is. Perfect - thanks!

olavmrk commented 10 years ago

We haven't updated the extension for the Australis Firefox theme, so for now it is hidden away in the menu bar. Unfortunately, I haven't had the time to look into how best to adapt it to the new layout yet. Patches welcome! :)

thijskh commented 10 years ago

I've taken a look. Maybe good to know is that this problem doesn't exist on Mac OS and Ubuntu, because that always shows the menu bar.

Other extensions that fall roughly in the same category as SAML Tracer seem to mostly add just an extra toolbar button to the interface (that is, a button next to the download and home buttons). To me, this may be a bit overkill for SAML Tracer which is perhaps too specialised to be always in the main view. A good alternative may be to add it to the "Developer" menu that's containtained inside the "Hamburger" menu. It seems on topic there and the developer menu tile has a nice wrench on it.

Firebug does this (besides adding a firebug icon to the toolbar btw). Not exactly a patch but here's how they do it: https://github.com/firebug/firebug/commit/4781195b70bfe1fa49ebf9984b42ba9517200b8a What do you think?

olavmrk commented 9 years ago

Hi,

I have now pushed 9281039f97, which adds a SAML-tracer button to the new menu.

(I opted to do that instead of the developers menu, since it seems like that is where they want extensions to add new buttons now.)