search

simplesamlphp / SAML-tracer

Browser extension for examining SAML messages
https://addons.mozilla.org/nl/firefox/addon/saml-tracer/
BSD 2-Clause "Simplified" License
143 stars 39 forks source link

FYI your manifest file in version 1.8.0 is still marked as 1.7.1 #94

Closed middleagedman closed 3 months ago

middleagedman commented 3 months ago

Also, the version isn't updated in the Firefox add-ons page either.

Thank you for this great extension!

tvdijen commented 3 months ago

That's for pointing out the manifest issue. v1.8.0 is indeed not released yet because Mozilla and Google have increased their demands on add-ons and we have yet to match their demands before we can upload the latest version to their add-on stores.

Blocked by #93

tvdijen commented 3 months ago

Seems there's progress on the blocking issue. I hope v1.8.0 can be officially released soon! If you don't mind, I'm closing this issue now. Thanks again for reporting!

khlr commented 2 months ago

I just uploaded version 1.8.0 to the Chrome Web Store and to AMO. 🚀 It may take some time until the new version is approved in the respective store.

One side note: I locally edited the manifest.json for the AMO upload because it rejected version 1.8.0 and stated it was uploaded before. This is correct. Back in 12/2023 I tried to publish version 1.8.0 which I then had to cancel after the privacy policy blocker appeared in the Chrome Web Store... Hence version 1.8.0 is blocked now. I changed it to 1.8.0.0 if anyone wonders...

EDIT: I just realized that we uploaded new version as major.minor in the past. So I just stopped 1.8.0.0 and changed it to 1.8 🙂

tvdijen commented 2 months ago

Was it refused by Mozilla, or what? Just minutes after you posted this, I saw it released for Chrome, but Firefox is still at 1.7.1..

khlr commented 2 months ago

No, it's still awaiting review:

image

Apparently the guys at AMO are taking things more seriously and a real person will be looking at it 😉

khlr commented 2 months ago

It's finally published :)

tvdijen commented 2 months ago

I was just going over the reviews on the Mozilla website and ran into a feature request to be able to maximize the add-on window. Do you know if that's even possible for a pop-up window?

Edit: It appears to be some weird limitation of Firefox on Windows. https://discourse.mozilla.org/t/browser-windows-create-type-popup-unable-to-maximize/93528

khlr commented 2 months ago

Yes, that has often bothered me too. But apparently there is no solution.