search

simplesamlphp / docker-simplesamlphp

A docker image for easy deployment of SimpleSAMLphp as either an Identity Provider or as a Service Provider.
GNU General Public License v2.0
22 stars 10 forks source link

Not explicit enough install instructions #1

Open llekn opened 4 years ago

llekn commented 4 years ago

Hi,

The README install instructions says:

To get started put the version of simplesamlphp you want to test in a folder named simplesamlphp

I wasted a couple of hours doing echo v1.18.6 > version and a lot of variations on the simplesamlphp folder, until I realized that this meant to put the source code of SimpleSAMLphp on that folder.

Doing a git clone https://github.com/simplesamlphp/docker-simplesamlphp.git and then checking out the desired version did the trick.

I think it would be easier for noobs like me to put this steps explicitly on the README (git clone ..., etc). (or better, to make this docker to checkout a specific version via a environment var)

prasannjeet commented 3 years ago

Nice idea! why not create a pull request with all the detailed instructions in the README? I am sure the author will be glad and approve it.

nabinkhadka commented 2 years ago

Ok, what do you mean by to put the source code of SimpleSAMLphp on that folder. ? :)

saridzawa commented 2 years ago

download simplesamlphp source code from official site and extract on that folder

mvaneijken commented 2 years ago

I did the following:

git clone https://github.com/simplesamlphp/docker-simplesamlphp.git
cd ./docker-simplesamlphp
git submodule add https://github.com/simplesamlphp/simplesamlphp.git

From this point you can select the version tag like this:

cd ./simplesamlphp
git checkout v1.19.5