dedrac
commented
4 months ago Board approved.
Closed monkeyiq closed 3 months ago
dedrac
commented
4 months ago Board approved.
monkeyiq
commented
3 months ago This has been received. Marking as complete. Thank you!
dedrac
commented
3 months ago Yay! Thanks for the update, Ben.
Dedra
On Mon, Jul 15, 2024 at 5:12 AM monkeyiq @.***> wrote:
This has been received. Marking as complete. Thank you!
— Reply to this email directly, view it on GitHub https://github.com/simplesamlphp/governance/issues/22#issuecomment-2228035626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHS6CVRXE6XWFEWO636L3ZMOG6XAVCNFSM6AAAAABKA4ETSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGAZTKNRSGY . You are receiving this because you commented.Message ID: @.***>
I have had a focus on pull requests this milestone. There are only two active PRs for 2024 now; one for a possible captcha addition and one to extend the authprocs to be able to run on authsources directly. Both of these are more for discussion rather than merging at this stage.
I had started doing some work on master but then switched focus to looking at issues and PRs. I think having my focus primarily on the PRs/issues is likely best as maintainer with a possible fallback to some master development during quiet periods.
Merged and cherry picked Azure2Name Attribute Mapping for SAML Claims https://github.com/simplesamlphp/simplesamlphp/pull/1997
Merged and cherry picked Document and remove configuration for StatisticsWithAttribute module https://github.com/simplesamlphp/simplesamlphp/pull/2002
It was found that in the past when SSP was loading translations from binary mo files the domain was not in the file. I added a fix for the release to ignore the domain in the po file load to work again while a more complete solution was created. i18n: when loading from po file the domain from the file has to be wiped https://github.com/simplesamlphp/simplesamlphp/pull/2010
Discussions about entity IDs https://github.com/simplesamlphp/simplesamlphp/pull/2014
An issue and pull request had been made to allow metadata to be loaded from a directory. This would allow many metadata files rather than single large files to cover all cases. I created an updated PR against a modern version and merged that. https://github.com/simplesamlphp/simplesamlphp/pull/2018
I updated the translation system to respect the domain in po files and function. This allows a module to have custom translations with fallbacks to the existing saml, core, messages. Respect the gettext domain for modules https://github.com/simplesamlphp/simplesamlphp/pull/2037
Review, research and eventual merge of SP Request Initiation Protocol PR . sp_request_initiation_protocol https://github.com/simplesamlphp/simplesamlphp/pull/2073
More internationalization work...created and merged. i18n notice new strings, check hooks, dig deeper in twig dirs https://github.com/simplesamlphp/simplesamlphp/pull/2051
I created a PR to potentially copy non empty translation strings over empty ones where multiple strings with the same key exist. It turned out there were not very many of these so I didn't merge the update because the additional code complexity was not justified for the few translation strings it would help translations: copy non empty translation for very core modules #2058 https://github.com/simplesamlphp/simplesamlphp/pull/2058
Session handling over SSP version updates. A PR was made to ignore failure to load sessions which would help migration. There was discussion on this and an eventual merge to allow it. I made a subsequent PR to log failure to help allow discovery of failing storage. https://github.com/simplesamlphp/simplesamlphp/pull/2065 https://github.com/simplesamlphp/simplesamlphp/pull/2094
Developed and merged. Start to allow adfs metadata in the admin ui again #2067 https://github.com/simplesamlphp/simplesamlphp/pull/2067
change adfs SSO from baseurl to prp endpoint #2080 https://github.com/simplesamlphp/simplesamlphp/pull/2080
MetaDataStorageHandler::getGenerated uses a hook to allow ADFS metadata https://github.com/simplesamlphp/simplesamlphp/pull/2082
Review and merge https://github.com/simplesamlphp/simplesamlphp/pull/2086 https://github.com/simplesamlphp/simplesamlphp/pull/2087 https://github.com/simplesamlphp/simplesamlphp/pull/2088 https://github.com/simplesamlphp/simplesamlphp/pull/2089 https://github.com/simplesamlphp/simplesamlphp/pull/2090 https://github.com/simplesamlphp/simplesamlphp/pull/2091 https://github.com/simplesamlphp/simplesamlphp/pull/2092 https://github.com/simplesamlphp/simplesamlphp/pull/2093
Review and merge Add support for returned config array in config files #2107
Created it seems this is hash_equals with the s at the end #2108
One of the above updates to move to more Symfony code (2086-2093 above) changed if admin passwords could be stored in plaintext. This lead to a discussion and a custom exception with a detailed message to warn the user that they must hash the admin password to continue. https://github.com/simplesamlphp/simplesamlphp/pull/2110 https://github.com/simplesamlphp/simplesamlphp/pull/2113
CI testing https://github.com/simplesamlphp/simplesamlphp/pull/2114
Update to the CI translations job created and merged. CI: translations job update to allow fetch/push to complete #2115
Review of https://github.com/simplesamlphp/simplesamlphp/pull/2131
Create and merge update of test suite for 2131 at Update test suite for no single string endpoints #2132
Created a prototype to allow custom error codes to be thrown from a module and have the template system present both custom and standard error messages. https://github.com/simplesamlphp/simplesamlphp/pull/2142
docs: add info about cachedir to base install info #2153 docs: upgrade command should leave user on a tag checkout #2154
I have left an explicit journal of comments in github issues for the months out of this log.