simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library
https://www.simplesamlphp.org
GNU Lesser General Public License v2.1
286 stars 135 forks source link

WIP Rewite the API provided by all classes under XML/md/ #208

Closed jaimeperez closed 4 years ago

jaimeperez commented 4 years ago

This is quite a big piece of work. Some details:

Some notes on the approach followed:

tvdijen commented 4 years ago

I was able to merge quite a good portion of this PR to master without breaking anything.. That way we at least have some of the individual commits + commit messages instead of one huge squashed commit.

codecov[bot] commented 4 years ago

Codecov Report

Merging #208 into master will increase coverage by 9.58%. The diff coverage is 98.09%.

@@             Coverage Diff              @@
##             master     #208      +/-   ##
============================================
+ Coverage     74.99%   84.57%   +9.58%     
+ Complexity     2294     2122     -172     
============================================
  Files           142      143       +1     
  Lines          5358     5393      +35     
============================================
+ Hits           4018     4561     +543     
+ Misses         1340      832     -508
tvdijen commented 4 years ago

Thanks, I had to run into a meeting :P

jaimeperez commented 4 years ago

No prob! 😄