simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library
https://www.simplesamlphp.org
GNU Lesser General Public License v2.1
286 stars 135 forks source link

Make processor aware of assertion types #242

Closed MKodde closed 4 years ago

MKodde commented 4 years ago

Integrates #240 into master

codecov[bot] commented 4 years ago

Codecov Report

Merging #242 into master will increase coverage by 0.12%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     87.84%   87.97%   +0.12%     
- Complexity     2404     2406       +2     
============================================
  Files           166      166              
  Lines          6016     6020       +4     
============================================
+ Hits           5285     5296      +11     
+ Misses          731      724       -7     
tvdijen commented 4 years ago

It's a nitpick, but could you add a bunch of use-statements to the test-file and squash the full namespaced class names?

MKodde commented 4 years ago

Absolutely. I thought the team preferred having less import statements in favor of instant readability what namespace a class hails from?

tvdijen commented 4 years ago

I've noticed that some of the analyzer tools do a better job with the use-statements in place.. We add the full namespaced classes for parameters to the phpdoc and i'm considering adding @uses tags for the others for instant readability.. It's hard to keep psr12 compliant if you put then inline in the code