search

simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library
https://www.simplesamlphp.org
GNU Lesser General Public License v2.1
286 stars 135 forks source link

Refactor BaseID/NameIDTypeBaseidtype #307

Closed tvdijen closed 2 years ago

tvdijen commented 2 years ago

This PR brings back the AbstractBaseIDType that is a mutual ancestor between BaseID and NameIDType. It also fixes the fact that we could encrypt Issuer, because encryption was implemented on the NameIDType rather than on the NameID.

tvdijen commented 2 years ago

Can't seem to figure out why the order of the BaseID-attributes is unstable, causing four of the PHPunit failures..