Registration authority consistency (simplesamlphp#1758)

[ghalse]

Change the RegistrationInfo toArray() and fromArray() methods to match SSP as at simplesamlphp#1758

[codecov[bot]]

Codecov Report

Merging #324 (0c2f0d2) into master (0b6ea6f) will increase coverage by 0.22%. The diff coverage is 85.29%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #324 +/- ## ============================================ + Coverage 87.19% 87.42% +0.22% - Complexity 1492 1504 +12 ============================================ Files 176 177 +1 Lines 5695 5781 +86 ============================================ + Hits 4966 5054 +88 + Misses 729 727 -2 ```

[tvdijen]

For master, our future v5 of this library, we took a lot of care in following the exact names from the specifications. I think this should be fixed the other way around, in SSP..

I would be fine merging this against the release-4.x branch though, and I think that's what you want considering you're merging https://github.com/simplesamlphp/simplesamlphp/pull/1758 against SSP@master as well? I take it you want this to land in SSP 2.0 final?

P.S.: Could it be that your fork of this lib is really old? Because I really can't explain the documentation-action failing

[ghalse]

I was fixing this in SSP rather than here. It was just done here for completeness/consistency with SSP. So far as I can tell, the toArray/fromArray aren't actually (yet) used in SSP. I only proposed this for completeness. I'd be happy to simply close this leaving it as-is, and fix the problem in SSP itself (if by making it more robust).

[tvdijen]

That's right, current SSP uses saml2 v4.x and will use that for a while (probably until SSP 3.0).