simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library
https://www.simplesamlphp.org
GNU Lesser General Public License v2.1
284 stars 134 forks source link

PHP 7.1 support and xmlseclibs #97

Closed chris1312 closed 7 years ago

chris1312 commented 7 years ago

simplesamlphp/saml2 depends on robrichards/xmlseclibs and it is using mcrypt_* functions. Therefore, using this library it results into deprecated errors.

Why using Mcrypt is wrong? Read here https://paragonie.com/blog/2015/05/if-you-re-typing-word-mcrypt-into-your-code-you-re-doing-it-wrong

Has anybody tested SAML2 with robrichards/xmlseclibs 3.0.0+?

thijskh commented 7 years ago

Yes, I've done some testing with simpleSAMLphp and OpenConext-engineblock and their core functionality remains working, also their testsuites pass with this upgrade. We need to keep it at "2.0 or 3.0" as saml2 currently still supports PHP < 5.6.

chris1312 commented 7 years ago

That's nice to hear. Thanks for the update!