simplesamlphp / simplesamlphp-module-adfs

This module adds support for WS-Federation

GNU Lesser General Public License v2.1

5 stars 5 forks source link

Feature/initial tests #10

Closed tvdijen closed 2 years ago

tvdijen commented 3 years ago

Supersedes #8 Closes #8

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (65c4b36) into master (1b1a3af) will increase coverage by 4.43%. The diff coverage is 28.57%.

@@             Coverage Diff             @@
##             master     #10      +/-   ##
===========================================
+ Coverage      0.00%   4.43%   +4.43%     
+ Complexity       78      77       -1     
===========================================
  Files             5       5              
  Lines           364     361       -3     
===========================================
+ Hits              0      16      +16     
+ Misses          364     345      -19

tvdijen commented 3 years ago

@pradtke I couldn't write to your repository, so I made a copy of #8 and improved it. I had to make some code changes though... Would it be possible for you to functionally test this branch?

pradtke commented 3 years ago

@tvdijen I ran the module (with SSP master branch) and I was able to view the ADFS metadata and authenticate and generate the WS-fed assertions. Looks good to me. Thanks for doing the updates.

tvdijen commented 3 years ago

Thanks! I'll try and raise coverage on the controller a bit more before I merge this. At least I know I didn't break anything